search

lirios / fluid

:book: Library for QtQuick apps with Material Design
https://docs.liri.io/sdk/fluid/develop/
Other
823 stars 112 forks source link

Add icons from materialdesignicons.com #27

Open plfiorini opened 8 years ago

plfiorini commented 8 years ago

This web site have plenty of useful icons https://materialdesignicons.com/ We are already using some of them for the shell but I'd like to have the shipped by Fluid alongside the official Material icons: the reason is that I'd like not to duplicate those and rather give a lot more selection to our users.

pasdam commented 6 years ago

Can I suggest to use a font for the icons instead of the single svg files? As it is far more efficient (for instance in the demo app the Material icons section is really slow now when the user opens it, but if you replace the svg images with text/label elements it become faster) and it allows to change the color easly. The downside though is that you can't reference the icons by name, but rather you have to use the unicode code. If you are willing to change I can suggest (in that case maybe I should open a new issue where we can discuss about it) the pattern that I'm using in my apps, and if you like I can also implement it.

plfiorini commented 6 years ago

There are better ways to make Material icons faster. Font icons will not work with QtQuick Controls 2.

pasdam commented 6 years ago

Can you be more specific about the "better ways"? maybe I can improve my apps as well. Anyway, I'm currently using Text elements and they work fine; at the time I wrote the previous comment I also replaced all the elements in Material icons section and it was faster.

plfiorini commented 6 years ago

First I doubt you will ever load that many icons at the same time in a real world application. The demo can be optimized by loading one category a time and with asynchronous loading.