Closed impact27 closed 8 years ago
Has this been tested on all platforms?
Maybe it should be made configurable?
For instance if you are trying to record frames for a video, you would rather it go a little slower and not sacrifice the frame rate.
I added a #ifdef APPLE so that only apple compiler will see this. The other plateform will just not compile this. I think this may work for linux as well
This will need to be tested on all platforms before pulling even in spite of the APPLE ifdef - just to be sure. Making it an option sounds like a good idea. @jauerb I think it will soon make sense to think about continuous integration, have you guys discussed that yet? ( http://jenkins-ci.org/ https://wiki.jenkins-ci.org/display/JENKINS/GitHub+Plugin ). That way, at least bugs breaking builds could already be caught with the current testing infrastructure (=0 :) ).
@tcies that sounds pretty interesting/useful. Do you have experience with Jenkins? Maybe we could discuss sometime?
@jauerb The lab I'm doing my Master thesis in uses it for continuous integration on github (unit tests and all), and it's pretty awesome. I haven't seen it from the admin side yet though. The fact that we need to test on three platforms and not just one might be an issue, I'll ask my supervisor about that (afaik he is Jenkins admin here).
See #42 for full discussion.