Cleaning Up: groundhog.datasets.

lisa-groundhog / GroundHog

Library for implementing RNNs with Theano

BSD 3-Clause "New" or "Revised" License

598 stars 229 forks source link

Cleaning Up: groundhog.datasets. #14

Closed rizar closed 9 years ago

rizar commented 9 years ago

This issue is a part of my initiative to leave only useful/used code in this main fork of Grounhog.

The following classes:

groundhog.dataset.TMIterator
groundhog.dataset.NNJMContextIterator

are not used in any of the groundhog-based projects I know. May I just delete them?

kyunghyuncho commented 9 years ago

I agree that they can safely be removed.

@rizar, what do you think about having a text file at each directory containing a list of removed classes with the commit # recorded? With this file, later, if anyone needs to look up the code for the already removed class, it'll make his/her life much easier.

rizar commented 9 years ago

@kyunghyuncho, I think there is no need in such a file. We will write commit messages like that:

 Cleaning up groundhog.datasets

 Delete TMIterator
 Delete NNJMContextIterator

and then one can search them to find when the class was deleted.