lisaac / luci-app-diskman

Disk Manager for LuCI
GNU Affero General Public License v3.0
400 stars 112 forks source link

feat: RAID creation: Automatically find and create next RAID device #51

Closed Hurricos closed 2 years ago

Hurricos commented 2 years ago

Note that the current default actually has a bug where, despite the placeholder saying '/dev/md0', the actual path created by default is /dev/md1.

This change moves to match the user's expectations by actually using the placeholder that they see.

Hurricos commented 2 years ago

Force-pushed to correct the authorship of the commit.

I could probably improve the commit message to mention that this actually does a search to find the next available RAID device, but the original code did already do that, it just didn't reflect it in the placeholder.

Hurricos commented 2 years ago

Oh, and I could probably change the commit message to "actually using the same logic to generate a placeholder as used to select the default (since the placeholder value is not communicated)."

lisaac commented 2 years ago

Thanks