search

lisachenko / z-engine

:zap: PHP Engine Direct API
MIT License
448 stars 22 forks source link

Is this package still supported? #55

Open Rastusik opened 2 years ago

Rastusik commented 2 years ago

Hey @lisachenko , is this package still supported? Does it make sense to create a pull request with php 8.1 support?

lisachenko commented 1 year ago

Hello, @Rastusik! I'm not actively working on OSS projects right now, but if you want to work on this - I can give you maintainer permissions on this project, or can review and merge your PRs to enable 8.1/8.2 repos.

Rastusik commented 1 year ago

@lisachenko that sounds great! I'm not really planning to be a real maintainer, but I can make contributions for PHP 8/8.1/8.2 support. If you think it's ok to give me maintainer permissions, I won't object, but I'm only planning to do work related to this: https://github.com/pixelfederation/swoole-bundle/blob/coroutines/docs/configuration-reference.md#additional-info-for-coroutines-usage . Which essentially is just support for newer php versions (with working tests of course). I won't have time for anything more.

Btw FYI even tests for PHP 8.0 are failing, I fixed them in my fork here: https://github.com/pixelfederation/z-engine/commits/8.0_fixes