search

lisachenko / zf2-aspect

Playground for integration of aspect-oriented programming into ZF2
BSD 3-Clause "New" or "Revised" License
10 stars 3 forks source link

zendframework needs to be set to 2.* in composer.json #3

Open bmerigan opened 5 years ago

bmerigan commented 5 years ago

Composer.json has zendframework/zendframework loading dev-master which is no longer ZF2, they've moved to ZF3. The composer.json file needs to lock zendframework to version 2.*

Tried to push an update for consideration but the repo is locked down.

I'll add here that lisachenko/go-aop-php requires zend-code": "^3.1" so could cause a conflict

lisachenko commented 5 years ago

Hi, is ZF2 still actual? I have a feeling, that old versions of Go! AOP should work with ZF2 without any issues. All modern versions of framework will use new ZF3. If you know about compatibility issues, then you could send a PR with changes in composer.json to prevent installation of incompatible versions.

lisachenko commented 5 years ago

Have you seen https://github.com/goaop/goaop-zf2-module and https://github.com/goaop/goaop-zend-expressive-middleware?

bmerigan commented 5 years ago

Given this repo is called zf2-aspect I assumed it was specifically for Zend Framework 2. I'm actually investigating the use of AOP for ZF1! Yes I've had a look at goaop-zf2-module. Will look at the other one mentioned.