lisad / phaser

The missing layer for complex data batch integration pipelines
MIT License
9 stars 1 forks source link

Fixes two broken tests, issue #142, and enables tests now they're fixed #144

Closed lisad closed 5 months ago

lisad commented 5 months ago

The tests are pretty descriptive:

Fixes #142

lisad commented 5 months ago

@YuliaS , I incorporated all of your tests except for the ones that try to apply a "fix_value_fn" that only works before the Column casts to a type.

To address those, I instead added some documentation that explains that fix_value_fn applies after casting to the declared type, so 'upper' and 'strip' won't work on an IntColumn or DateColumn, but contrariwise, 'abs' will work on an IntColumn because it's already cast to an int.