search

lisamelton / other_video_transcoding

Other tools to transcode videos.
MIT License
543 stars 24 forks source link

Change help layout to make filter usage more obvious #120

Open martinpickett opened 2 years ago

martinpickett commented 2 years ago

When running other-transcode --help full the "Video options" section includes several references to FFmpeg filters interspersed throughout, as well as the --no-filters option. To make it clearer what are filters and what are not could we have a "Video filters" section?

From what I can see the following would be in the new section: crop, 720p, 1080p, deinterlace, detelecine, no-filters & yadif-parameters.

lisamelton commented 2 years ago

@martinpickett I will consider that. But it will take some significant code duplication and refactoring because some of those filters (i.e. --crop and --720p) are visible with the default --help behavior. And I don't want another section in the default.

martinpickett commented 2 years ago

Good point, I had not considered that. Is it easier to just move all the filters to the end of the section, then at least they are grouped, even if the group is not named?

lisamelton commented 2 years ago

I've done that already for --help and --help more. With --help full the only thing after the filters are --rc-maxrate, --rc-bufsize and --copy-video. And I put those last because I don't want people actually using them. :)

martinpickett commented 2 years ago

I understand. While I believe a "Video filter" section would be beneficial, I see it would be awkward to implement. Please feel free to close this issue if you think it is too much work.

lisamelton commented 2 years ago

@martinpickett Thanks. I've actually been thinking about this a lot more over the last day or so and I probably will close it. But not because it would be too much work. I'm just reluctant to add a "Filter options" section to the default --help output just for --crop and --720p, which are the only two filters listed in that scope. Otherwise I would be moving those two from "Video options" into the new section only when the expanded more and full scopes are displayed. And that seems weird to me.