lisamelton / other_video_transcoding

Other tools to transcode videos.
MIT License
549 stars 25 forks source link

Add VAAPI to HEVC 10bit bitrate reduction #26

Closed skj-dev closed 4 years ago

skj-dev commented 4 years ago

When using VAAPI with HEVC the bitrate stays at 8000Kbps instead of being reduced to 6000Kbps like with the other encoders. It looks like this is because vaapi isn't being matched in the @ten_bit regex.

I just added it to that list. 😄

I'm assuming that is the correct thing to match, since the result of the try_encoder function is successful with:

Trying "hevc_vaapi" video encoder...

skj-dev commented 4 years ago

Sadly, it looks like HEVC is totally busted when used with VAAPI. 😭 😭

I'm closing this PR since setting the bitrate doesn't matter. The encoded file ends up being encoded with an order of magnitude lower bitrate that is basically unusable.

In fact, it might be worthwhile checking if --hevc has been passed and VAAPI is being used, and kick out if so. 😦