lisamelton / other_video_transcoding

Other tools to transcode videos.
MIT License
549 stars 25 forks source link

Forced subtitles not burning #27

Closed wintervaler closed 4 years ago

wintervaler commented 4 years ago

Hey team, I recently ripped a couple of new additions to my library, both Marvel/Disney - Thor: The Dark World (2013) and Captain America: The First Avenger (2011). Both films are the Blu-ray release.

Both have (very brief) forced subtitles for foreign audio (or, in the case of The Dark World, alien audio) that are properly triggered and show up on the screen when playing back the originally ripped MKVs in IINA or VLC. But when I use the --burn-subtitle auto argument with other-transcode, neither video transcodes with the burned-in subtitle. I fear that this has happened on other films I’ve transcoded as well (going back to my pre-transcode-video and other-transcode days), though I don’t mind going through and spot-checking my favorite films and adding forced SRTs from online where necessary, as I did with these two when I realized they lacked the correctly burned-in subs.

But going forward (or possibly to repeat the process with at least these two films) - what’s the best way to ensure forced tracks are included? It may involve more media discovery up front by working with the original full rips.

Happy to include additional media info or my other-transcode string if needed.

lisamelton commented 4 years ago

@wintervaler My apologies for taking so long to respond. I somehow missed the notification from GitHub.

The reason why --burn-subtitle auto failed for you is that the subtitle track in your input file didn't have the "forced" attribute set. This is how automatic subtitle behavior works, whether it's burning or adding. My older transcode-video tool had the same requirement.

I explain this in detail here on the wiki:

https://github.com/donmelton/other_video_transcoding/wiki/Subtitles

You can tell whether other-transcode will detect your forced subtitle track prior to transcoding by using the --dry-run option.

And you can set the "forced" attribute in your input file using the mkvpropedit tool if that flag is missing. For example, to set the "forced" attribute on the first subtitle in your input file, you could do something like this:

mkvpropedit --edit track:s1 --set flag-forced=1 input.mkv

BTW, burning subtitles will slow the speed of transcoding. If your playback devices supports it, you should consider adding the subtitle as is to your output file, i.e. using --add-subtitle auto instead.

Does that answer your question?

wintervaler commented 4 years ago

So sorry for my delay in responding to this, Don! I somehow did not realize that when I selected the subtitle tracks in MakeMKV it didn't automatically mark the ones titled as "Forced Only" with the appropriate MKV "forced" flag. This has been very informative and I'm clearly going to have to teach myself to use mkvpropedit - good call.

My only worry about --add-subtitle, which I may start using anyway, is that while I can direct play PGS just fine on my Apple TV at home, it might needlessly force a transcode if I am remote streaming from Plex (then again, plain old SRT makes this happen sometimes too, so maybe it's a crapshoot).

lisamelton commented 4 years ago

@wintervaler No worries on the delay.

Yeah, Plex deciding to re-transcode is both dependent on your client capabilities and your bandwidth so, as they say, your mileage may vary. And if Plex does decide to re-transcode for reasons of bandwidth, then it's likely it would do that whether you had already burned in the subtitles or not.

Did you have any other questions?

wintervaler commented 4 years ago

What's your latest preferred method for your library - adding the Blu-ray format subtitles to save time or burning them in?

Other than that - no, no questions! Thanks again.

On Wed, Apr 15, 2020 at 11:49 AM Don Melton notifications@github.com wrote:

@wintervaler https://github.com/wintervaler No worries on the delay.

Yeah, Plex deciding to re-transcode is both dependent on your client capabilities and your bandwidth so, as they say, your mileage may vary. And if Plex does decide to re-transcode for reasons of bandwidth, then it's likely it would do that whether you had already burned in the subtitles or not.

Did you have any other questions?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/donmelton/other_video_transcoding/issues/27#issuecomment-614120630, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOQKKWZ63OVWCP5RMCQ3PUTRMXJQDANCNFSM4LWXVV7A .

-- Alex Butcher-Nesbitt abutchernesbitt@gmail.com c: (603) 707-6153 @alexbn27

lisamelton commented 4 years ago

@wintervaler I add subtitles now rather than burn them in because 1) it's faster and 2) all my devices finally support playback of image-based subtitles.

OK, I'll close this now but feel free to continue commenting.