search

lisamelton / other_video_transcoding

Other tools to transcode videos.
MIT License
549 stars 25 forks source link

updating escape command to current MPV requirements #35

Closed hubertron closed 4 years ago

hubertron commented 4 years ago

When running this command mpv --no-audio --vf lavfi=[drawbox=0:140:1920:800:invert:1] "D:\Movies\moviename.mkv"

or this one

mpv --no-audio --vf crop=1920:800:0:140 "D:\Movies\moviename.mkv"

using the latest version of MPV

mpv 0.32.0-456-g4e94b2177a Copyright © 2000-2020 mpv/MPlayer/mplayer2 projects built on Sun May 10 23:34:45 +08 2020  
FFmpeg library versions:   
libavutil       56.43.100  
libavcodec      58.83.100  
libavformat     58.43.100  
libswscale      5.6.101  
libavfilter     7.80.100  
libswresample   3.6.100  
FFmpeg version: git-2020-05-10-5727b1f13

The following error is generated:

Make sure you're using e.g. '--vf=value' instead of '--vf value'.
Exiting... (Fatal error)

This pull requests slightly edits the escape command to PS to include the correct code snippet to copy and paste.

lisamelton commented 4 years ago

@hubertron I was wondering when anyone else would notice this problem. :)

Thanks for the patch! But I actually have this fixed for both the other_video_transcoding and video_transcoding Gems in my local tree. And I'll probably release the new versions tomorrow or Monday.

lisamelton commented 4 years ago

@hubertron I've finally checked in my change which you can see here: https://github.com/donmelton/other_video_transcoding/commit/bd889231bff56d34e64aab242d79e5c5e0dab6dd

So I will close this now. Thanks again.