search

lisamelton / video-transcoding-scripts

Utilities to transcode, inspect and convert videos.
MIT License
603 stars 76 forks source link

Remove trailing whitespaces #12

Closed vitorgalvao closed 9 years ago

vitorgalvao commented 9 years ago

Damn that sneaky trailing whitespace, always introducing itself uninvited, and thank you perl for making it so easy to delete it.

lisamelton commented 9 years ago

Damn indeed! :) I can't believe I missed those. Shame on me.

I'll merge this shortly when I'm back at my desk.

Thanks for catching those!

lisamelton commented 9 years ago

Those were so simple I decided to just merge them from the GitHub website. :)

BTW, I prefer to use the present tense and active voice for checkin comments, as well as full sentence capitalization and punctuation.

Of course, I'll still take a sensible patch without those. :)

vitorgalvao commented 9 years ago

Took a look at the commit messages and also noticed you don’t specify the altered file, so I updated #11 to being only one commit with a sentence structure more in line with the rest.

lisamelton commented 9 years ago

Thanks! I just noticed as I was typing a comment into that pull request. :)

lisamelton commented 9 years ago

BTW, specifying the altered file is not a bad idea. You're making me think I should re-evaluate my checkin comment policy. :)

I'll let you know on that one.