search

lisamelton / video-transcoding-scripts

Utilities to transcode, inspect and convert videos.
MIT License
603 stars 76 forks source link

Added extract-subtitles.sh #17

Closed t089 closed 9 years ago

t089 commented 9 years ago

Hi Don! This is the wrapper for mkvextract I am using to extract subtitle tracks from a MKV file. Using the --language option you can pick subtitles of a specific language. Each track is saved as a file X_code.sup, where X is the integer track id and code is the language code of this track. Every track is saved with the sup extension. Not sure how much sense this makes... The script works well for DVD and Blu-Ray input. But isn't tested for edge cases. Best Tobias

t089 commented 9 years ago

Regarding the --burn scan option: apparently I've lost this change to some git merge f*ck up on my part...

lisamelton commented 9 years ago

Tobias,

Sorry I took so long to respond. I left your pull request open for quite some time hoping others might comment. Alas, no one did.

It looks like you might have based your script on convert-video.sh? If so, that's actually a pretty good choice for the framework.

I particularly like your idea for the --language CODE option. But you might want to store multiple codes in an array rather than a string. They would be easier to validate and iterate that way. You should at least check that the CODE input really does look like a language code. Since, I believe, that they're always lowercase ASCII and three characters long, that should be easy.

However, I'm not inclined to take the merge request since this isn't really a script about video transcoding --- it's about ripping instead. And I don't want to cross over into that territory as ripping really requires a much more extensive toolset than just this one script.

So, I'll turn this down now, but I may come knocking if I ever do that project. :)

Thanks for the patch!