search

lisamelton / video-transcoding-scripts

Utilities to transcode, inspect and convert videos.
MIT License
603 stars 76 forks source link

aspect ratio #19

Closed jhawk28 closed 9 years ago

jhawk28 commented 9 years ago

It would be nice to pass in the aspect ratio for when handbrake doesn't properly set it. I have had a few videos that take a 720x480 output 640x480.

lisamelton commented 9 years ago

Sorry I took so long to reply.

Adding this will make the code handling the automatic behavior much more complicated. :) But I'm willing to consider it.

I assume you want to specify the aspect ratio as a boundary then? That is, with --width and --height options?

jhawk28 commented 9 years ago

Yes, --width and --height

lisamelton commented 9 years ago

OK, I think I can do this just by changing the the pixel aspect ratio with HandBrake's --custom-anamorphic option. That way you can specify only --width, only --height, or both.

I'll put this on my feature list for a release I'm planning on in the next two weeks. And I'll leave this issue open until the feature goes in or I hit a wall with the implementation.

lisamelton commented 9 years ago

I finally got around to implementing it tonight. Seems to work fine but I'll wait to release it after I test it and the other new features more. It'll probably be out in a few days.

jhawk28 commented 9 years ago

thanks much

lisamelton commented 9 years ago

While these new options seem to work for some folks, I think an aspect ratio-specific option might be better. So I'm planning on adding that to the rewrite of the scripts that I'm working on now. Since that rewrite will be a Ruby-based Gem, it's unlikely I'll back-port it to my Bash-based shell scripts.

So I'm closing this now.