search

lisamelton / video_transcoding

Tools to transcode, inspect and convert videos.
MIT License
2.39k stars 160 forks source link

query-handbrake-log "frame rate not found" on latest HandBrakeCLI logs #326

Open carabino opened 3 years ago

carabino commented 3 years ago

I set up a new WSL2 instance of Ubuntu 20.04.1 on my Windows 10 machine, and transcoding is successful but extracting the time via query-handbrake-log fails:

user@system:~$ query-handbrake-log t . /usr/local/bin/query-handbrake-log: frame rate not found: /path/to/log/video.mp4.log user@system:~$

Looks to be a change in the output from HandBrakeCLI, as I do see a "frame rate:" line in the log on my old WSL1 Ubuntu 16.04.7 instance that I don't see in this log. This appears to be the key per line 142 of https://github.com/donmelton/video_transcoding/blob/master/bin/query-handbrake-log for rate_line variable.

Old: [14:41:42] video track [14:41:42] + decoder: mpeg2video [14:41:42] + bitrate 25000 kbps [14:41:42] + filters [14:41:42] + Framerate Shaper (mode=0) [14:41:42] + frame rate: same as source (around 23.976 fps) [14:41:42] + Crop and Scale (width=1920:height=1080:crop-top=0:crop-bottom=0:crop-left=0:crop-right=0) [14:41:42] + source: 1920 1080, crop (0/0/0/0): 1920 1080, scale: 1920 1080 [14:41:42] + Output geometry [14:41:42] + storage dimensions: 1920 x 1080 [14:41:42] + pixel aspect ratio: 1 : 1 [14:41:42] + display dimensions: 1920 x 1080

New: [22:16:23] * video track [22:16:23] + decoder: mpeg2video [22:16:23] + bitrate 200 kbps [22:16:23] + Output geometry [22:16:23] + storage dimensions: 1920 x 1080 [22:16:23] + pixel aspect ratio: 1 : 1 [22:16:23] + display dimensions: 1920 x 1080

Does not appear to impact speed, bitrate, or ratefactor information options, only time.

Old HandBrakeCLI is 1.1.2, new is 1.3.1.

I am benchmarking so the source file is same on both machines.

lisamelton commented 3 years ago

@carabino I'm sorry you're having this problem.

Have you tried using the old version of HandBrakeCLI, meaning 1.1.2, on your new Ubuntu installation?

carabino commented 3 years ago

Not yet, rookie mistake on my part

Although it looks like that is the only version installed. I believe I used an alternate PPA for the older Ubuntu so I will track that down to see if I can downgrade using it.

lisamelton commented 3 years ago

@carabino Thanks! I will await your update.

carabino commented 3 years ago

Could not downgrade on Ubuntu 20.04. Added the alternate PPA to the 20.04 and upgraded to 1.3.3, same result.

However installed Ubuntu 18.04 from the Microsoft Store, added the PPA, and installed 1.2.1 there. Ran the transcode and the log was successfully able to be read by query-handbrake-log.

From stdout: "Elapsed time: 00:25:03"

user@system:~$ query-handbrake-log t . 00:22:56 video.mp4

Log file has the "frame rate:" line: [19:45:24] video track [19:45:24] + decoder: mpeg2video [19:45:24] + bitrate 200 kbps [19:45:24] + filters [19:45:24] + Framerate Shaper (mode=0) [19:45:24] + frame rate: same as source (around 23.976 fps) [19:45:24] + Crop and Scale (width=1920:height=1080:crop-top=0:crop-bottom=0:crop-left=0:crop-right=0) [19:45:24] + source: 1920 1080, crop (0/0/0/0): 1920 1080, scale: 1920 1080 [19:45:24] + Output geometry [19:45:24] + storage dimensions: 1920 x 1080 [19:45:24] + pixel aspect ratio: 1 : 1 [19:45:24] + display dimensions: 1920 x 1080

Seems to be a change somewhere between 1.2.1 and 1.3.1 then.

lisamelton commented 3 years ago

@carabino Thanks for all the testing! Yeah, It appears the HandBrake team has, once again, changed their diagnostic/log format. This will be fun to figure out a fix. And by "fun," I mean not fun.