ruby 2.7.0p0, HandBrake 1.3.3, ffmpeg version 4.2.4-1ubuntu0.1, Ubuntu 20.04
I ran transcode-video --dry-run on a bunch of DVD directory rips and a couple of .mkv and .mp4 files with no options and compared the output between video_transcoding-0.25.3 and video_transcoding-0.26.0 (this PR). The output for all of those was the same. When I added --crop detect --add-audio "spa" --add-subtitle "eng,spa", the only difference was that subtitle tracks were correctly added. My video library is very limited, however, and I didn't play with any of the other options.
convert-videodoesn't always select the correct streams (the stream IDs aren't available in the HandBrake JSON output). Should now select the streams correctly, though it will only get the first video stream (which I think matches the old behavior, and is probably the most common use case).
detect-crop seems unaffected.
TODOs:
Add stream IDs to media.info. They are not available in the JSON output, so they need to be found elsewhere.
Uses the
HandBrakeCLI --json
option to get media info.Tested with
I ran
transcode-video --dry-run
on a bunch of DVD directory rips and a couple of .mkv and .mp4 files with no options and compared the output between video_transcoding-0.25.3 and video_transcoding-0.26.0 (this PR). The output for all of those was the same. When I added--crop detect --add-audio "spa" --add-subtitle "eng,spa"
, the only difference was that subtitle tracks were correctly added. My video library is very limited, however, and I didn't play with any of the other options.convert-video
doesn't always select the correct streams (the stream IDs aren't available in the HandBrake JSON output).Should now select the streams correctly, though it will only get the first video stream (which I think matches the old behavior, and is probably the most common use case).detect-crop
seems unaffected.TODOs:
Add stream IDs to media.info. They are not available in the JSON output, so they need to be found elsewhere.