bluelovers commented 4 years ago

sometime we need use responseUrl,

for example: use with jsdom and jquery for get dom prop href

codecov[bot] commented 4 years ago

Codecov Report

Merging #141 into master will decrease coverage by 0.58%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage     100%   99.41%   -0.59%     
==========================================
  Files          12       12              
  Lines         170      172       +2     
==========================================
+ Hits          170      171       +1     
- Misses          0        1       +1

Impacted Files	Coverage Δ
src/request.js	`100% <100%> (ø)`	:arrow_up:
src/serialize.js	`88.88% <50%> (-11.12%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b49888c...9ebf623. Read the comment docs.

ghost commented 3 years ago

Hey @bluelovers 🙂

I'd love to get this merged (more than a year later, sorry) but would you mind adding tests so code coverage doesn't decrease?

Cheers

ghost commented 3 years ago

Also, would you mind posting an example of a situation where these modifications become necessary?

lisaogren / axios-cache-adapter

feat(cache): cache `request.res.responseUrl` #141

Codecov Report