lisaogren / axios-cache-adapter

Caching adapter for axios. Store request results in a configurable store to prevent unneeded network requests.

MIT License

726 stars 107 forks source link

feat: update axios to v0.20.x (#214) #215

Closed jahead closed 3 years ago

jahead commented 4 years ago

All tests past locally fixes #214

codecov[bot] commented 4 years ago

Codecov Report

Merging #215 (7fbe6f6) into master (137f392) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #215   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          177       177           
=========================================
  Hits           177       177

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 137f392...7fbe6f6. Read the comment docs.

ajhenry commented 4 years ago

@RasCarlito Anyway we can get this merged in? There was a fix with how axios interacts with proxies released in 0.19 that would be really nice to have

teklakct commented 4 years ago

👍

jahead commented 4 years ago

@RasCarlito Everything okay mate? We haven't heard from you?

joselcc commented 3 years ago

any plan to this being merged?

merobal commented 3 years ago

The latest is now v0.21.1

merobal commented 3 years ago

@RasCarlito any plan to update this?

teklakct commented 3 years ago

In my project, a temporary fix is made by setting axios in a specific version in dependencies.

merobal commented 3 years ago

The previous versions contain vulnerabilities :( (only fixed in v0.21.1)

jahead commented 3 years ago

I'm not sure what we should do here, the maintainer hasn't responded to anything. And we need a new release. Can we temporarily fork the project, and publish an alternative until rascalito gets back on his feet? I hope he's okay!

Get Outlook for Androidhttps://aka.ms/ghei36

From: Bálint notifications@github.com Sent: Friday, January 22, 2021 6:29:28 AM To: RasCarlito/axios-cache-adapter axios-cache-adapter@noreply.github.com Cc: jahead joshua.head@outlook.com; Author author@noreply.github.com Subject: Re: [RasCarlito/axios-cache-adapter] feat: update axios to v0.20.x (#214) (#215)

The previous versions contain vulnerabilities :( (only fixed in v0.21.1)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/RasCarlito/axios-cache-adapter/pull/215#issuecomment-764883298, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGV5AH7PZDL4KVG4ZWQU3TS3B6BRANCNFSM4RRL3MLA.

maxwellsmart84 commented 3 years ago

Wow this thread is active - i am ok with the forking - does anyone know the maintainer?

maxwellsmart84 commented 3 years ago

@jahead can you bump axios to the latest and then fork this to another repo?

teklakct commented 3 years ago

Please put a link here to the forked repository

jahead commented 3 years ago

https://github.com/jahead/axios-cache-adapter Okay, I've bumped and run the tests, it all checks out. I just quickly bumped the axios to "~0.21.1" for peer and dev deps.

I also rebuilt the dist folder.

This is just a stop gap. We should probably put this fork under a organization, and find out who wants to put time into reviewing the current PRs. and we need to publish to the npm store - I'm just praying @RasCarlito will poke his head in.

we could do @axios-cache/adapter?

maxwellsmart84 commented 3 years ago

I sent a LinkedIn message/request to @RasCarlito to ask him about maintaining this library. Maybe we will get a response, all his contact information is on his GH profile though.

jahead commented 3 years ago

Yea I've sent him an email as well hopefully we can get through to him

Get Outlook for Androidhttps://aka.ms/ghei36

From: Maxwell Krause notifications@github.com Sent: Saturday, January 23, 2021 2:24:55 AM To: RasCarlito/axios-cache-adapter axios-cache-adapter@noreply.github.com Cc: jahead joshua.head@outlook.com; Mention mention@noreply.github.com Subject: Re: [RasCarlito/axios-cache-adapter] feat: update axios to v0.20.x (#214) (#215)

I sent a LinkedIn message/request to @RasCarlitohttps://github.com/RasCarlito to ask him about maintaining this library. Maybe we will get a response, all his contact information is on his GH profile though.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/RasCarlito/axios-cache-adapter/pull/215#issuecomment-765481865, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGV5AHFUUDPE6VLIIAKI5LS3GKEPANCNFSM4RRL3MLA.

jahead commented 3 years ago

@maxwellsmart84 we should wait for a response before making an issue about it, maybe Monday?

I've also parked the spaces. If we pull the trigger on this, I'll make a issue.

genesiscz commented 3 years ago

For now

npm install https://github.com/jahead/axios-cache-adapter.git

worked

teklakct commented 3 years ago

source

jahead commented 3 years ago

@RasCarlito Yea! if you need any help mate, please let us know. We use this project internally so I can put some work time to helping!

I'll close out the organizations that I parked