It is not caching GET request having query strings

[AbhishekPrajapati]

It caches GET requests but when any GET request has query string, It is not caching.

Example URL is like: 'api/candidates?active=true'

const cachedAPIs = [
  "api/candidates",
  "api/candidates?active=true"
];

  const storageInfo = localforage.createInstance({
        driver: [
            localforage.LOCALSTORAGE,
        ],
        name: 'my_cache'
    });

    const cache = setupCache({
        maxAge: 15 * 60 * 1000,
        store: storageInfo,
        key: req =>  req.url.replace(window.APP_CONFIG.API_URL, ''),
        exclude: {
            filter: (req, a) => {
                if (req.method.toLowerCase() === 'get' && cachedAPIs && cachedAPIs.indexOf(req.url.toLowerCase()) != -1) {
                    return false;
                }
                return true;
            }
        },
        clearOnStale: true,
    });

Am I missing anything?

[ghost]

Hey @AbhishekPrajapati

Thanks for using axios-cache-adapter.

By default requests with query parameters are excluded from cache. You need to set the exclude.query option to false.

const cache = setupCache({
    maxAge: 15 * 60 * 1000,
    store: storageInfo,
    key: req =>  req.url.replace(window.APP_CONFIG.API_URL, ''),
    exclude: {
        query: false, // allow to cache requests with query parameters
        filter: (req, a) => {
            if (req.method.toLowerCase() === 'get' && cachedAPIs && cachedAPIs.indexOf(req.url.toLowerCase()) != -1) {
                return false;
            }
            return true;
        }
    },
    clearOnStale: true,
});

Be advised, the query parameters are serialized and used in the cache key so requests to the same URL with different query parameters are cached separately 🙂

I'll let you close the issue if all is good.

Cheers

[ghost]

Check out the full list of options: https://github.com/RasCarlito/axios-cache-adapter#setupcacheoptions

[AbhishekPrajapati]

Yeap @RasCarlito, That is working properly by setting exclude.query option to false.

I appreciate your quick response.