search

lisaogren / axios-cache-adapter

Caching adapter for axios. Store request results in a configurable store to prevent unneeded network requests.
MIT License
726 stars 107 forks source link

Remove `constructor.name` assertion #264

Open OiYouYeahYou opened 2 years ago

OiYouYeahYou commented 2 years ago

This breaks current compatibility with the current redis version and causes an unreasonable expectation of future changes in the future

Fixes: #263

codecov[bot] commented 2 years ago

Codecov Report

Merging #264 (19e7cfb) into master (2d51cee) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #264   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          235       229    -6     
=========================================
- Hits           235       229    -6
Impacted Files Coverage Δ
src/redis.js 100.00% <ø> (ø)
src/serialize.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d51cee...19e7cfb. Read the comment docs.

anish-joy commented 2 years ago

When are you guys planning to fix this issue, its still breaking while connecting to Redis

OiYouYeahYou commented 2 years ago

@anish-joy unfortunately I reached out to @RasCarlito just before Christmas last year but haven't heard anything back. At this point I think it's fair to declare this as an abandoned project 😔

265 has an alternative listed

anish-joy commented 2 years ago

@OiYouYeahYou Thanks for the update! I really appreciate it