lisawray / groupie

Groupie helps you display and manage complex RecyclerView layouts.
MIT License
3.66k stars 293 forks source link

Failed to resolve dependency #404

Closed jblejder closed 3 years ago

jblejder commented 3 years ago

Describe the bug On fresh project failed to resolve

implementation "com.github.lisawray.groupie:groupie:2.9.0"
implementation "com.github.lisawray.groupie:groupie-viewbinding:2.9.0"

I have

subprojects {
    repositories {
        maven { url "https://jitpack.io" }
    }
}

in root gradle file

although previous identifier works fine

implementation "com.xwray:groupie:2.9.0"
implementation "com.xwray:groupie-viewbinding:2.9.0"

Is it only me? I'm not sure what I'm doing wrong.

So I think the Readme needs to be changed or make it available on new package.

ScottCooper92 commented 3 years ago

It's definitely on there https://jitpack.io/#lisawray/groupie/2.9.0

Zhuinden commented 3 years ago

I think it's the subprojects that's causing you trouble, for me it's always been allprojects {.

Zhuinden commented 3 years ago

I found the real cause, which is that new projects get a NEW block where you ALSO need to add the repository.

dependencyResolutionManagement {
    repositoriesMode.set(RepositoriesMode.FAIL_ON_PROJECT_REPOS)
    repositories {
        google()
        mavenCentral()
        maven { url 'https://jitpack.io' }  // <--
        jcenter() // Warning: this repository is going to shut down soon
    }
}

This is inside settings.gradle. I need to update the Readme to include this.

Zhuinden commented 3 years ago

https://github.com/lisawray/groupie/commit/bc3c799b8cbb08ddf5f450b8f9b62f84aff33a84