search

lishid / OpenInv

Open anyone's inventory as a chest, real-time!
GNU General Public License v3.0
120 stars 97 forks source link

Update to 1.14 #101

Closed Jikoo closed 5 years ago

Jikoo commented 5 years ago

Just popping this issue open so you all know I'm aware of 1.14 and am going to slowly progress on it.

Jikoo commented 5 years ago

A note for those of you using the OpenInv API - due to changes required in 1.14, I've been forced to revisit a couple of methods. As such, I'm bumping the revision a major version and removing the existing deprecated methods.

Jikoo commented 5 years ago

I don't have a testing environment set up, and I'm out of time for today. Untested build, please report any issues. OpenInv.zip

For the more faint of heart, I'll probably set up a testing environment tomorrow.

Jikoo commented 5 years ago

For you brave souls who downloaded the build, it's a good thing I made a mistake in SpecialPlayerInventory, because not opening is probably better than improper slot count yielding pretty severe client desync. Most of the way to a proper fix, but I likely won't have any time to devote to it for another couple days.

dudefoxlive commented 5 years ago

Hello, I'm new and would like to know how to put this in my environment to test. Since its not a .jar file i'm quite lost on what to do.

RoboMWM commented 5 years ago

Download file and rename the .zip to .jar

ImLunaUwU commented 5 years ago

Hey, so i am an idiot when it comes to compiling things, and was wondering if you could possibly just send me the latest compiled version (for 1.14 ofc) asap? Thanks :)

RoboMWM commented 5 years ago

@MajorLOLGaming

Download file and rename the .zip to .jar

Jikoo commented 5 years ago

@MajorLOLGaming the only release so far is in a previous post in this issue thread.

For anyone using the API, I apologize for the fluctuations. It turns out that while opening an InventoryView allows us to rename the view, Spigot does not support custom Container sizes for existing InventoryViews. While this is technically a Spigot bug and could be reproduced in an API-only plugin, for the sake of not altering the OpenInv API so much I'm planning to add a new method to circumvent it.

For those of you interested, another snapshot: OpenInv.zip Opened player inventories will be named "Chest" on 1.14 but otherwise everything seems to be in order.

Jikoo commented 5 years ago

While going through the update process, it occurred to me at several points that my life would have been made significantly easier by being able to access Java 8 features. I'll be releasing one last version with full backwards compatibility. After that, OpenInv will be dropping support for Java versions <8. With that, I also see no reason to continue to maintain support for such a huge quantity of outdated versions.

When I took over maintaining OpenInv, there were enough dupe bugs and longstanding issues to warrant backporting bugfixes to older versions, but at this point it's just a barrier that prevents other developers getting involved. I plan on maintaining only 1.8.8 and whatever happen to be the latest 2 major revisions at the time. In the future, OpenInv will require the current Minecraft release's minimum Java version, despite what older supported versions may allow.

Jikoo commented 5 years ago

4.0.0