search

lishid / OpenInv

Open anyone's inventory as a chest, real-time!
GNU General Public License v3.0
120 stars 97 forks source link

Console error at start #111

Closed AuracleTech closed 5 years ago

AuracleTech commented 5 years ago

13:16:33 [WARNING] Plugin OpenInv v4.0.3 does not specify an api-version.

Easy to fix

Jikoo commented 5 years ago

OpenInv supports 1.8, 1.13, and 1.14 currently. Spigot does not allow specifying older API versions, and will not load plugins which do specify them.

AuracleTech commented 5 years ago

Then add api-version 1.8 so it knows to get the 1.8 API at minimum Just to remove warning message

AuracleTech commented 5 years ago

Oh ok Just understood your message, welp.... rip spigot, pretty sure there s a way tho

Jikoo commented 5 years ago

Yeah, the only way is to specify api-version 1.13 or higher. Technically that would probably be fine, but since a) it's not really a problem and b) it's not actually true - the plugin is built against 1.8.8, I don't really want to include it.

I suppose it's worth reconsidering. This isn't an isolated request, it's a duplicate of #102. Would appreciate community feedback.

Jikoo commented 5 years ago

Actually, after more thought, I am likely to include api-version 1.13. The last time it came up I was opposed to it, but OpenInv's nature is that it is somewhat version-specific and volatile. There is likely (very slight) additional unnecessary processing associated with OpenInv for legacy support it doesn't actually require. In addition, not including the API version would cause it to be a bit more annoying to do pretty printing for things like #35 if I ever get around to it.

AuracleTech commented 5 years ago

Would be logic, cause api-version start from 1.13 so just adding the lowest api-version supported would fix the warning I think