search

lishid / OpenInv

Open anyone's inventory as a chest, real-time!
GNU General Public License v3.0
120 stars 97 forks source link

OpenInv keeps containers open #176

Closed leasoncre closed 3 years ago

leasoncre commented 3 years ago

Paper 1.16.5-457 if ii open a container when not in vanish, the container stays visually open for any client that has been in the area when it was opened by an admin (this includes shulker boxes that increase their hitbox, and stay open) only fix is to relog/re-place container

tested on shulker box, chest, and large_chest. when openinv is unloaded on test server, new chests/unopened-chests don't stay open.

Jikoo commented 3 years ago

Sounds like an incompatibility with your vanish plugin. Please reproduce using only OpenInv.

Jikoo commented 3 years ago

I'm gonna write up a boilerplate explanation as to why that's probably happening here because this is the second of these issues in 2 days.

The reason you're likely seeing containers "freeze open" is that you are running a vanish plugin that attempts to implement its own SilentContainer functionality. Unfortunately, most vanish plugins cancel packets and cause Minecraft's internals to become confused. Because the internals are in the wrong state or the packets were intercepted, the close packets do not get sent to the client. OpenInv, instead of messing around with packets and producing invalid server states, forces the container to treat the user as a spectator. This has the same effect - trapped chests don't trigger, sounds and animations don't play - while preventing the server from getting confused about what packets should be sent when.

If your vanish plugin has the capability, have it disable OpenInv's SilentContainer functionality while enabled.

leasoncre commented 3 years ago

i use SuperVanish, which also states it uses the spectator mode to open chests.... BUT at no point was i in vanish, so it shouldn't be related?

Jikoo commented 3 years ago

Please reproduce using only OpenInv.

leasoncre commented 3 years ago

for some reason i had openinv.silent FALSE set on my player in LuckPerms, WITH it enabled.... must have done derped ages ago and never looked into it. +Removing that node and turning it off fixed the issue thank you -fixed/resolved

leasoncre commented 3 years ago

ONE thing to note with this is that after changing the silentchest setting to off... .containers already stuck open do not fix themselves until relogging (not even by re-opening them, which i would have expected to work)