search

lishid / OpenInv

Open anyone's inventory as a chest, real-time!
GNU General Public License v3.0
120 stars 97 forks source link

Fix & improve UUID retrieval #29

Closed ShadowRanger closed 9 years ago

ShadowRanger commented 9 years ago

lishid I was really confused to what you meant by the custom method of checking to see if we're on the main thread so I wasn't able to add it here and instead used the method that Bukkit provides. I understood what you meant but I just wasn't sure how you wanted me to implement it. By that I mean UUIDUtils.getUUIDOf is only called in a couple of the commands and the config updater and I wasn't sure under what circumstances the method would be called with the boolean as true or false. If you'd rather me do it I'd be happy to but if possible please try and explain how you meant it because I'm a little bit confused, sorry.

So just let me know if you're happy with this pull request or would like me to make any changes to it.

lishid commented 9 years ago

Looks good for now, I'll make some adjustments later on maybe.

ShadowRanger commented 9 years ago

Would you like me to compile the code and update the plugin on BukkitDev?

lishid commented 9 years ago

Would be cool if you can do that, thanks! (Also sorry, I've been out without internet for two days)