search

lishid / OpenInv

Open anyone's inventory as a chest, real-time!
GNU General Public License v3.0
120 stars 97 forks source link

Chests play the open sound with /silentchest. #68

Closed jacklollz2 closed 7 years ago

jacklollz2 commented 7 years ago

Spigot 1.12. Both me and the players hear the open sound when using /silentchest

RoboMWM commented 7 years ago

Plugins? Did you try with just Openinv installed?

jacklollz2 commented 7 years ago

Tried it with only that plugin. Still having the issue.

Jikoo commented 7 years ago

I'll look into it when I get a chance, Mojang probably changed where the sound is played. Probably not tonight, maybe tomorrow depending on how some IRL plans end up finalizing.

Jikoo commented 7 years ago

Had a bit of a poke around, looks like the easiest fix is essentially one of the options I presented in Jikoo/OpenInv#11, forcing the player to be treated as a spectator when opening the container. It'll also simplify the process of dealing with shulker boxes, assuming I manage properly.

Jikoo commented 7 years ago

Actually, I cannot reproduce this. Please provide logs, exact server version, OpenInv version, and any other relevant information.

jacklollz2 commented 7 years ago

OpenInv is the latest version. 3.2.1. Spigot is PaperSpigot latest, however default Spigot has the same issue. Paper version git-Paper-1143 (MC: 1.12) (Implementing API version 1.12-R0.1-SNAPSHOT) latest.log

Jikoo commented 7 years ago

This is an issue with PaperSpigot, not Spigot. Default Spigot does not have the same issue.

Jikoo commented 7 years ago

I have not tested this on 1.11 and do not have time currently, but you're welcome to rename and use OpenInv.zip - tested and working on both Spigot and PaperSpigot 1.12.

jacklollz2 commented 7 years ago

Huh, I wonder why I had this issue on Spigot as well. I guess it was just because I updated asap since the server needs to be the latest version, and the snapshot build was the issue. But thank you!

Jikoo commented 7 years ago

Works fine, 3.3.0 is now tagged. Will do a Bukkit release tonight, I'm pushing it already for leaving for work :V