search

lisitsyn / tapkee

A flexible and efficient С++ template library for dimension reduction
http://tapkee.lisitsyn.me
BSD 3-Clause "New" or "Revised" License
232 stars 57 forks source link

Complete quoting for parameters of some CMake commands #14

Closed elfring closed 8 years ago

elfring commented 10 years ago

Some parameters (like "${CMAKE_CURRENT_SOURCE_DIR}/lib" and "${CMAKE_BINARY_DIR}") are passed to CMake commands in your build script without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like spaces.

I would recommend to apply advices from a Wiki article.

elfring commented 10 years ago

Would you like to reconsider a few implementation details once more?

lisitsyn commented 10 years ago

Absolutely! Let me fix them. Thanks

elfring commented 8 years ago

Thanks for your improvement of the affected build script.

How do you think about to integrate another small update like the following?

-           include_directories(${GTEST_SOURCE_DIR})
-           include_directories(${GTEST_INCLUDE_DIR}/include)
+           include_directories("${GTEST_SOURCE_DIR}" "${GTEST_INCLUDE_DIR}/include")
lisitsyn commented 8 years ago

@elfring thanks! Updated that in 215f7e0fdcecd59ad8107c77c97dc2236fbefc12