lisitsyn / tapkee

A flexible and efficient С++ template library for dimension reduction
http://tapkee.lisitsyn.me
BSD 3-Clause "New" or "Revised" License
231 stars 58 forks source link

ENH: make tapkee compile even in case of multiple inclusions #43

Closed YannLePoul closed 7 years ago

YannLePoul commented 7 years ago

There were missing many inline keywords in function implementation, some problems with static variable initialization (that usually needs to be in the cpp file), and a problem with way of using method traits to have compile time information on classes.

lisitsyn commented 7 years ago

Thanks a lot! Just a few minor issues then we can merge it.

lisitsyn commented 7 years ago

Thanks again!

YannLePoul commented 7 years ago

Happy to help !