lisiyao21 / Bailando

Code for CVPR 2022 paper "Bailando: 3D dance generation via Actor-Critic GPT with Choreographic Memory"
Other
382 stars 59 forks source link

Error when processing the data #10

Closed LaLaLailalai closed 2 years ago

LaLaLailalai commented 2 years ago

Hi,

image

The index of the preprocessing code "_prepro_aistpp.py" seems to be wrong, cause there is no such file in the folder. Do you know how to fix it?

lisiyao21 commented 2 years ago

Yes I know. This is caused by the last line of the split txt file which doesn't contain an '\n' and the last digit was filterd. You could add addtional ones to them. I will also make an update today. I am sorry for troubling you. Thank you for your patience and for your interest~

kevink2424 commented 2 years ago

' [-1] ==> strip() ' cloud solve it. In https://github.com/lisiyao21/Bailando/blob/9c5afbba8d07a24c0499deaf693cbb72a799c9de/_prepro_aistpp.py#L65 https://github.com/lisiyao21/Bailando/blob/9c5afbba8d07a24c0499deaf693cbb72a799c9de/_prepro_aistpp.py#L70

LaLaLailalai commented 2 years ago

Thanks! I already fixed it by changing train[-1] and test[-1] to the right file name.

LaLaLailalai commented 2 years ago

' [-1] ==> strip() ' cloud solve it. In

https://github.com/lisiyao21/Bailando/blob/9c5afbba8d07a24c0499deaf693cbb72a799c9de/_prepro_aistpp.py#L65

https://github.com/lisiyao21/Bailando/blob/9c5afbba8d07a24c0499deaf693cbb72a799c9de/_prepro_aistpp.py#L70

Thanks for your solution! I already fixed it by changing train[-1] and test[-1] to the right file name.

lisiyao21 commented 2 years ago

Guys, please note that I have make an update. PLEASE DO NOTE that the original paper test on validation (20) and test (20) sets both. This was done by hard code when I did but it only processed test set in your version . Please re-process the data using new code. Otherwise, the test results can be different~

lisiyao21 commented 2 years ago

Guys, please note that I have make an update. PLEASE DO NOTE that the original paper test on validation (20) and test (20) sets both. This was done by hard code when I did but it only processed test set in your version . Please re-process the data using new code. Otherwise, the test results can be different~

@LaLaLailalai @kevink2424

kevink2424 commented 2 years ago

@lisiyao21 Thank you !