search

liske / needrestart

Restart daemons after library updates.
GNU General Public License v2.0
426 stars 67 forks source link

properly detect dhclient #262

Closed anarcat closed 8 months ago

anarcat commented 1 year ago

We make the call here that dhclient should be detected, if not properly restarted. We try to workaround the problem that restarts fail or destroy the network by adding ifupdown to the long list of services that cannot be restarted.

We've been running an equivalent configuration in production at the Tor Project over about 100 Debian machines running Debian buster and bullseye for months without negative issues.

Closes: #225

liske commented 1 year ago

Thanks for the suggestion. I wonder if there might be other setups (i.e. network-manager using dhclient?) which could result in a regression.

anarcat commented 1 year ago

well NetworkManager is already listed in the ignore list here, so the point of this PR is really to unify the way we block such cases, to remove the "ifup special case" that seems to be why we don't process dhclient normally.

anarcat commented 11 months ago

any reason this is not merged? can i help?

liske commented 8 months ago

Thanks! Sadly I was very busy.