search

liske / needrestart

Restart daemons after library updates.
GNU General Public License v2.0
426 stars 67 forks source link

fix AMD ucode checking in non-debug mode #288

Closed anarcat closed 8 months ago

anarcat commented 11 months ago

It looks like the assignment when the ucode exist was not done unless debug (-v) was set. Therefore, all AMD microcode checks were returning UNKNOWN, including in Nagios checks, unless the -v ("verbose", but actually debug) was passed.

Closes: #249

anarcat commented 11 months ago

i tested this on our fleet. it works on two of the 4 affected AMD hosts. those two hosts do have the right firmware version loaded from the /lib/firmware blobs.

the two hosts that still report UNKNOWN simply do not do not have a firmware file available in there. that is what #285 aims to fix, but I'm not sure we should fix this in the first place... after all the Intel code has the same behavior, as @mmitch mentioned in #226... so i'm not fixing that here and will resolve that problem out of band, by removing the check for those hosts.

alternatively, if we do want to fix that issue, we should do it for Intel as well...

anarcat commented 11 months ago

alternatively, if we do want to fix that issue, we should do it for Intel as well...

edit: fup in https://github.com/liske/needrestart/pull/285#issuecomment-1813258928 instead.

liske commented 8 months ago

Thanks! Their was also #278 pending fixing the same issue.