search

liskin / strava-map-switcher

Map switcher for Strava website
GNU General Public License v3.0
71 stars 20 forks source link

Update arrive.min.js from 2.3.1 to 2.4.1 #15

Closed Strajk closed 4 years ago

Strajk commented 4 years ago

Ahoj 🇨🇿 First of all, thx for this extension, using it all the time :)

I'm contributing to another Strava extension https://github.com/lamby/strava-enhancement-suite, where I also use arrive.js to detect changes.

Problem is, it hooks onto the global window and the extension which loads first "wins" and the code of the other extension is using the arrive.js from the first.

That's an issue cause we are using functionality added in 2.4.1, namely support for arrow functions.

image

If we would sync on the version, it would allow both extensions to live happily together :))

liskin commented 4 years ago

Merged with a more detailed commit message as 81baaf582f0320da65bc30f53ce32cab6647a920. Released as v0.14.1. Thanks!

Strajk commented 4 years ago

@liskin wow, that was fast :) thx 🚴‍♀️