search

liskin / strava-map-switcher

Map switcher for Strava website
GNU General Public License v3.0
71 stars 20 forks source link

dirty fix #19

Closed peatfaerie closed 1 year ago

peatfaerie commented 1 year ago

quick and dirty fix for recent changes in the strava route builder (just to give an idea what's changed); I can't do it properly at the moment but I hope this will help somehow anyway

liskin commented 1 year ago

Did you have an idea of what "doing it properly" would look like? After looking at your change I'm thinking that we can just always try both of reactInternalInstance/reactFiber and both of mapFromReactInternalInstance/mapFromReactFiber, rather than only doing mapFromReactFiber when reactFiber finds something. It's still a hack probably but doesn't seem harmful. I can't really be bothered studying what React actually does in different versions.

Anyway, thanks a lot for figuring this out! ❤ I'll try to take a closer look next week (expecting to be somewhat less busy but no promises really).

peatfaerie commented 1 year ago

It seems that Strava updated its version of React so I believe it is safe to assume that reactInternalInstance is gone and sticking to reactFiber will suffice. I cleaned up the fix a bit.