search

lisongmechlab / lsml

Li Song Mech Lab
http://lisongmechlab.github.io/lsml/
GNU General Public License v3.0
42 stars 6 forks source link

Alpha Strike heat % drops when adding a weapon. #779

Closed LiSongMWO closed 2 years ago

LiSongMWO commented 2 years ago

Steps to reproduce:

  1. Open http://t.li-soft.org/?l=rwFMAAAAAAAAAAAAAACSpynKUISkCFxQuIAl%2FMLiAVQ%3D
  2. Add 1 SLAS

Actual result: Alpha heat drops to 98%.

Expected result: Alpha heat goes up, or at least doesn't drop.

LiSongMWO commented 2 years ago

The discussion in #770 is resolved. I currently have no reason to believe tha LSML computes the ghost heat incorrectly in the presence of heat generation modifiers on the weapons.

Regarding the wierdness in the second comment. This is caused by how the alpha heat is calculated. It's calculated as the heat at the end of the alpha, not the peak heat during the alpha.... It might also compute it slightly wrong. This needs some more thought and effort.

LiSongMWO commented 2 years ago

It seems reasonable that alpha heat % should show the highest heat % that was observed during the firing.