suite.lisp - list-all-suites is ill-defined

lispci / fiveam

Common Lisp regression testing framework

BSD 3-Clause "New" or "Revised" License

186 stars 33 forks source link

suite.lisp - list-all-suites is ill-defined #101

Open homedirectory opened 1 year ago

homedirectory commented 1 year ago

The following function is defined in src/suite.lisp:

(defun list-all-suites ()
  "Returns an unordered LIST of all suites."
  (hash-table-values *suite*))

The problem with it is that variable *suite* is not used to store a hash table of all suites, but the current test suite object. Fortunately, this function is not used anywhere at the moment, and the corresponding symbol is not even exported.

Perhaps, *toplevel-suites* was intented to be used?

homedirectory commented 1 year ago

Aha! I found https://github.com/lispci/fiveam/pull/4, and it seems that variable *suites* had been introduced previously, and used in list-all-suites. However, the associated commit no longer belongs to any existing branch's history, so I guess it was removed later.