lispci / fiveam

Common Lisp regression testing framework
BSD 3-Clause "New" or "Revised" License
186 stars 33 forks source link

Extend the set of comparison operations permitted #92

Open rpgoldman opened 1 year ago

rpgoldman commented 1 year ago

I wanted to be able to use alexandria:set-equal as a comparison operation in FiveAM tests. This turned out to be impossible (except by using test-true), because the is macro did not accept extra, modifier arguments such as

(set-equal x y :test 'equalp)

The reason for this limitation was that FiveAM used a home-brewed matching construct to process is forms in tests.

In this PR I have replaced FiveAM's home-brew matcher (which was only used in one place in the code) by a dependency on the "trivia" pattern-matching library. This was a judgment call, but figuring out the undocumented list matcher seemed more trouble than it was worth.