lispercat / sailpoint-iiq-dev-accelerator

VSCode extension to accelerate and facilitate development by directly interacting with the target Sailpoint IIQ server
MIT License
31 stars 10 forks source link

Check the SSB's x.secret.properties in addition to target.properties for ECLIPSE_ tokens #16

Closed drosenbauer closed 3 years ago

drosenbauer commented 3 years ago

This will reduce the risk of accidentally committing critical passwords into source control.

lispercat commented 3 years ago

I found a reference to ${target}.target.secret.properties in scripts/build.config.xml (wonder why they duplicate "target" in the file name. ${target}.secret.properties would be enough) Is that what you are referring to? Thanks, I will keep that in mind as a feature request.

On Wed, Jun 16, 2021 at 2:24 PM Devin Rosenbauer @.***> wrote:

This will reduce the risk of accidentally committing critical passwords into source control.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lispercat/sailpoint-iiq-dev-accelerator/issues/16, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACCZBZU4NC26L2ZFWBX3XLTTDT6NANCNFSM462AFORQ .

lispercat commented 3 years ago

Devin, I added the feature that you requested. Please verify that it works for you.

On Wed, Jun 16, 2021 at 2:24 PM Devin Rosenbauer @.***> wrote:

This will reduce the risk of accidentally committing critical passwords into source control.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lispercat/sailpoint-iiq-dev-accelerator/issues/16, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACCZBZU4NC26L2ZFWBX3XLTTDT6NANCNFSM462AFORQ .

lispercat commented 3 years ago

Implemented and closed