lispercat / sailpoint-iiq-dev-accelerator

VSCode extension to accelerate and facilitate development by directly interacting with the target Sailpoint IIQ server
MIT License
30 stars 11 forks source link

Properties File caching? #19

Closed derek-hackbardt-sp closed 2 years ago

derek-hackbardt-sp commented 2 years ago

Made a change to a env.target.properties file, saved the file. Then attempted to deploy a file with tokens, the deploy used the old values. Happens performing either a 'deploy open files' or 'import current file'.

Is there an action that is needed between updating a token and deploying a file using one or is the extension doing some caching of the properties that needs to get refreshed?

If I edit/touch the env.target.secret.properties file, the properties change is then properly reflected in the deploy.

Version 1.0.27

lispercat commented 2 years ago

Thanks for the report, I'll take a look.

On Thu, Dec 16, 2021 at 11:22 AM derekhackbardt @.***> wrote:

Made a change to a env.target.properties file, saved the file. Then attempted to deploy a file with tokens, the deploy used the old values. Happens performing either a 'deploy open files' or 'import current file'.

Is there an action that is needed between updating a token and deploying a file using one or is the extension doing some caching of the properties that needs to get refreshed?

Restarting vscode will causes the valid properties to be used.

Version 1.0.27

— Reply to this email directly, view it on GitHub https://github.com/lispercat/sailpoint-iiq-dev-accelerator/issues/19, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACCZB6ZLU2AL2SW2CJPY6TURIG2ZANCNFSM5KGXLOUA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

lispercat commented 2 years ago

I tried the "import current file" and I can't seem to reproduce it. Steps: 1) Put a new token in my sandbox.target.properties 2) Edit a rule using the token 3) Import the rule 4) Execute the rule 5) Repeat steps 1-4 with a new value of the same token

Probably you either missed saving a the .target.properties file or saving you rule file before importing. The only time I used the cached version of the .target.properties file is when it's content doesn't change (that the file's mtime stays the same). BTW, I have "file autosave" turned on, so every edit that I make to a file gets automatically saved. See if you can call "File: Toggle Auto Save" from the command palette to turn it on for the test.

On Thu, Dec 16, 2021 at 5:52 PM Andrei Stebakov @.***> wrote:

Thanks for the report, I'll take a look.

On Thu, Dec 16, 2021 at 11:22 AM derekhackbardt @.***> wrote:

Made a change to a env.target.properties file, saved the file. Then attempted to deploy a file with tokens, the deploy used the old values. Happens performing either a 'deploy open files' or 'import current file'.

Is there an action that is needed between updating a token and deploying a file using one or is the extension doing some caching of the properties that needs to get refreshed?

Restarting vscode will causes the valid properties to be used.

Version 1.0.27

— Reply to this email directly, view it on GitHub https://github.com/lispercat/sailpoint-iiq-dev-accelerator/issues/19, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACCZB6ZLU2AL2SW2CJPY6TURIG2ZANCNFSM5KGXLOUA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

derek-hackbardt-sp commented 2 years ago

It worked as expected with just a target.properties file - it wasn't until I used a target and target secret file.    If I have a secret file it wasn't seeing the changes made to the target file(if I remember).  I can also double check the steps after the holidays.

On Dec 18, 2021, 10:34 AM, at 10:34 AM, Lispercat @.***> wrote:

I tried the "import current file" and I can't seem to reproduce it. Steps: 1) Put a new token in my sandbox.target.properties 2) Edit a rule using the token 3) Import the rule 4) Execute the rule 5) Repeat steps 1-4 with a new value of the same token

Probably you either missed saving a the .target.properties file or saving you rule file before importing. The only time I used the cached version of the .target.properties file is when it's content doesn't change (that the file's mtime stays the same). BTW, I have "file autosave" turned on, so every edit that I make to a file gets automatically saved. See if you can call "File: Toggle Auto Save" from the command palette to turn it on for the test.

On Thu, Dec 16, 2021 at 5:52 PM Andrei Stebakov @.***> wrote:

Thanks for the report, I'll take a look.

On Thu, Dec 16, 2021 at 11:22 AM derekhackbardt @.***> wrote:

Made a change to a env.target.properties file, saved the file. Then attempted to deploy a file with tokens, the deploy used the old values. Happens performing either a 'deploy open files' or 'import current file'.

Is there an action that is needed between updating a token and deploying a file using one or is the extension doing some caching of the properties that needs to get refreshed?

Restarting vscode will causes the valid properties to be used.

Version 1.0.27

— Reply to this email directly, view it on GitHub

https://github.com/lispercat/sailpoint-iiq-dev-accelerator/issues/19, or unsubscribe

https://github.com/notifications/unsubscribe-auth/AACCZB6ZLU2AL2SW2CJPY6TURIG2ZANCNFSM5KGXLOUA . Triage notifications on the go with GitHub Mobile for iOS

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Reply to this email directly or view it on GitHub: https://github.com/lispercat/sailpoint-iiq-dev-accelerator/issues/19#issuecomment-997218750 You are receiving this because you authored the thread.

Message ID: @.***>

lispercat commented 2 years ago

good point, let me check the scenario when a secret file is present as well.

On Sat, Dec 18, 2021 at 8:00 PM derekhackbardt @.***> wrote:

It worked as expected with just a target.properties file - it wasn't until I used a target and target secret file. If I have a secret file it wasn't seeing the changes made to the target file(if I remember). I can also double check the steps after the holidays.

On Dec 18, 2021, 10:34 AM, at 10:34 AM, Lispercat @.***> wrote:

I tried the "import current file" and I can't seem to reproduce it. Steps: 1) Put a new token in my sandbox.target.properties 2) Edit a rule using the token 3) Import the rule 4) Execute the rule 5) Repeat steps 1-4 with a new value of the same token

Probably you either missed saving a the .target.properties file or saving you rule file before importing. The only time I used the cached version of the .target.properties file is when it's content doesn't change (that the file's mtime stays the same). BTW, I have "file autosave" turned on, so every edit that I make to a file gets automatically saved. See if you can call "File: Toggle Auto Save" from the command palette to turn it on for the test.

On Thu, Dec 16, 2021 at 5:52 PM Andrei Stebakov @.***> wrote:

Thanks for the report, I'll take a look.

On Thu, Dec 16, 2021 at 11:22 AM derekhackbardt @.***> wrote:

Made a change to a env.target.properties file, saved the file. Then attempted to deploy a file with tokens, the deploy used the old values. Happens performing either a 'deploy open files' or 'import current file'.

Is there an action that is needed between updating a token and deploying a file using one or is the extension doing some caching of the properties that needs to get refreshed?

Restarting vscode will causes the valid properties to be used.

Version 1.0.27

— Reply to this email directly, view it on GitHub

https://github.com/lispercat/sailpoint-iiq-dev-accelerator/issues/19, or unsubscribe

< https://github.com/notifications/unsubscribe-auth/AACCZB6ZLU2AL2SW2CJPY6TURIG2ZANCNFSM5KGXLOUA

. Triage notifications on the go with GitHub Mobile for iOS

< https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android

< https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Reply to this email directly or view it on GitHub:

https://github.com/lispercat/sailpoint-iiq-dev-accelerator/issues/19#issuecomment-997218750 You are receiving this because you authored the thread.

Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/lispercat/sailpoint-iiq-dev-accelerator/issues/19#issuecomment-997308521, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACCZB3HUM6573P2HHSF4M3URUVELANCNFSM5KGXLOUA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

lispercat commented 2 years ago

Derek, I found the bug, will try to provide a fix around holidays

On Sat, Dec 18, 2021 at 10:23 PM Andrei Stebakov @.***> wrote:

good point, let me check the scenario when a secret file is present as well.

On Sat, Dec 18, 2021 at 8:00 PM derekhackbardt @.***> wrote:

It worked as expected with just a target.properties file - it wasn't until I used a target and target secret file. If I have a secret file it wasn't seeing the changes made to the target file(if I remember). I can also double check the steps after the holidays.

On Dec 18, 2021, 10:34 AM, at 10:34 AM, Lispercat @.***> wrote:

I tried the "import current file" and I can't seem to reproduce it. Steps: 1) Put a new token in my sandbox.target.properties 2) Edit a rule using the token 3) Import the rule 4) Execute the rule 5) Repeat steps 1-4 with a new value of the same token

Probably you either missed saving a the .target.properties file or saving you rule file before importing. The only time I used the cached version of the .target.properties file is when it's content doesn't change (that the file's mtime stays the same). BTW, I have "file autosave" turned on, so every edit that I make to a file gets automatically saved. See if you can call "File: Toggle Auto Save" from the command palette to turn it on for the test.

On Thu, Dec 16, 2021 at 5:52 PM Andrei Stebakov @.***> wrote:

Thanks for the report, I'll take a look.

On Thu, Dec 16, 2021 at 11:22 AM derekhackbardt @.***> wrote:

Made a change to a env.target.properties file, saved the file. Then attempted to deploy a file with tokens, the deploy used the old values. Happens performing either a 'deploy open files' or 'import current file'.

Is there an action that is needed between updating a token and deploying a file using one or is the extension doing some caching of the properties that needs to get refreshed?

Restarting vscode will causes the valid properties to be used.

Version 1.0.27

— Reply to this email directly, view it on GitHub

https://github.com/lispercat/sailpoint-iiq-dev-accelerator/issues/19, or unsubscribe

< https://github.com/notifications/unsubscribe-auth/AACCZB6ZLU2AL2SW2CJPY6TURIG2ZANCNFSM5KGXLOUA

. Triage notifications on the go with GitHub Mobile for iOS

< https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android

< https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Reply to this email directly or view it on GitHub:

https://github.com/lispercat/sailpoint-iiq-dev-accelerator/issues/19#issuecomment-997218750 You are receiving this because you authored the thread.

Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/lispercat/sailpoint-iiq-dev-accelerator/issues/19#issuecomment-997308521, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACCZB3HUM6573P2HHSF4M3URUVELANCNFSM5KGXLOUA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

lispercat commented 2 years ago

Derek, I posted a fix with the latest version 1.0.31. Please check

derek-hackbardt-sp commented 2 years ago

Looks like its working. Thanks!!