search

lispercat / sailpoint-iiq-dev-accelerator

VSCode extension to accelerate and facilitate development by directly interacting with the target Sailpoint IIQ server
MIT License
31 stars 11 forks source link

&& is replaced in attribute value #50

Closed yannick-beot-sp closed 1 year ago

yannick-beot-sp commented 1 year ago

The extension is "naively" replacing all && by &&. For workflows, && can be used for conditions. However, they must not be replaced in order to be a valid XML.

lispercat commented 1 year ago

I agree, there are cases where it shouldn't be done. I need to make it smarter so that it would only replace them within CDATA tags

On Thu, Mar 23, 2023 at 3:17 AM yannick-beot-sp @.***> wrote:

The extension is "naively" replacing all && by &&. For workflows, && can be used for conditions. However, they must not be replaced in order to be a valid XML.

— Reply to this email directly, view it on GitHub https://github.com/lispercat/sailpoint-iiq-dev-accelerator/issues/50, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACCZB53YW323YMUOEQZT73W5P2H7ANCNFSM6AAAAAAWEZPXHE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

yannick-beot-sp commented 1 year ago

I have worked on it. I'll make a proposition if you want.

lispercat commented 1 year ago

Awesome, thanks!

On Thu, Mar 23, 2023, 11:52 yannick-beot-sp @.***> wrote:

I have worked on it. I'll make a proposition if you want.

— Reply to this email directly, view it on GitHub https://github.com/lispercat/sailpoint-iiq-dev-accelerator/issues/50#issuecomment-1481440834, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACCZB7QPQQ24CBUVS3ZGADW5RWSFANCNFSM6AAAAAAWEZPXHE . You are receiving this because you commented.Message ID: @.***>

lispercat commented 1 year ago

We merged the PR, can close the ticket now