search

lispgames / cl-sdl2

Common Lisp bindings for SDL2 using C2FFI.
MIT License
304 stars 82 forks source link

Don't interrupt if the current thread is the main thread #148

Closed ellisvelo closed 2 years ago

ellisvelo commented 2 years ago

This pull request addresses a problem where the examples don't run on MacOS. The change prevents the main thread from being interrupted.

How to Reproduce with SBCL:

  1. (ql:quickload :sdl2/examples)
  2. (sdl2:make-this-thread-main #'sdl2-examples:basic-test)
mfiano commented 2 years ago

Could you please fix this as to not mix tabs with spaces (this project uses spaces, and one of your lines is indented with a tab character). This will not look correct on other editors/configurations, and proper indentation is important for Lisp to be readable.

ellisvelo commented 2 years ago

No problem. I removed the tab. I'm using Emacs which has a default of spaces and tabs.

mfiano commented 2 years ago

Thanks!