lispyclouds / contajners

An idiomatic, data-driven, REPL friendly clojure client for OCI container engines
https://cljdoc.org/d/org.clojars.lispyclouds/contajners/
MIT License
134 stars 6 forks source link

Add docker API v1.45 support #25

Closed rafaeldelboni closed 7 months ago

rafaeldelboni commented 7 months ago

Hey thanks for this lib I've being testing it and is working fine with docker v1.44, I think would be nice to update it to the recent version.

lispyclouds commented 7 months ago

Hey, thanks for this! Would be releasing with this changes shortly!

lispyclouds commented 7 months ago

Released in 1.0.5

rafaeldelboni commented 7 months ago

Hey using org.clojars.lispyclouds/contajners {:mvn/version "1.0.5"} I'm getting the following error message:

{:message
 "client version 1.45 is too new. Maximum supported API version is 1.44"}

Here is the minimal reproduction code:

(def containers-docker (c/client {:engine :docker
                                    :category :containers
                                    :version  "v1.45"
                                    :conn     {:uri "unix:///var/run/docker.sock"}}))

  (c/invoke containers-docker
            {:op   :ContainerCreate
             :params {:name "clojure"}
             :data {:Image "clojure:temurin-11-tools-deps"
                    :WorkingDir "/usr/src/app"
                    :Cmd  ["clojure" "-M" "solution.clj"]}})
rafaeldelboni commented 7 months ago

Yeah sorry, for now looks like that latest docker on macs is 1.44.

Server: Docker Desktop 4.28.0 (139021)
 Engine:
  Version:          25.0.3
  API version:      1.44 (minimum version 1.24)