lit / lit-element

LEGACY REPO. This repository is for maintenance of the legacy LitElement library. The LitElement base class is now part of the Lit library, which is developed in the lit monorepo.
https://lit-element.polymer-project.org
BSD 3-Clause "New" or "Revised" License
4.49k stars 319 forks source link

Replace local type declarations for polyfill APIs with those imported from the polyfills. #1208

Closed bicknellr closed 3 years ago

bicknellr commented 3 years ago

This PR removes the local types describing the polyfill APIs in favor of the new TS externs from the polyfill repos.

github-actions[bot] commented 3 years ago

📊 Tachometer Benchmark Results

Summary

callback

  • shack: unsure 🔍 -1% - +2% (-0.23ms - +0.57ms)
    this-change vs master

Results

shack
  • Browser: chrome-headless 92.0.4515.107
  • Sample size: 330
  • Built by: Benchmarks #40
  • Commit: a51adb4
VersionAvg timevs this-changevs mastervs previous-2.x-release
this-change24.66ms - 25.20ms-unsure 🔍
-1% - +2%
-0.23ms - +0.57ms
unsure 🔍
-0% - +2%
-0.08ms - +0.61ms
master24.47ms - 25.06msunsure 🔍
-2% - +1%
-0.57ms - +0.23ms
-unsure 🔍
-1% - +2%
-0.27ms - +0.46ms
previous-2.x-release24.46ms - 24.88msunsure 🔍
-2% - +0%
-0.61ms - +0.08ms
unsure 🔍
-2% - +1%
-0.46ms - +0.27ms
-

tachometer-reporter-action v2 for Benchmarks

bicknellr commented 3 years ago

For some reason, I can't add @sorvell as a reviewer.