search

lit26 / finvizfinance

Finviz analysis python library.
https://finvizfinance.readthedocs.io/en/latest/
MIT License
507 stars 83 forks source link

table change for overview #46

Closed JerBouma closed 2 years ago

JerBouma commented 2 years ago

Hey @lit26, within group.overview the table value on line 85 needs to be changed. Currently this is set to table = soup.findAll("table")[5] but should be table = soup.findAll("table")[7]. Could you fix this minor detail please?

lit26 commented 2 years ago

It seems multiple pages on finviz have changed. I will check the full package.

JerBouma commented 2 years ago

Thank you for the quick response!

lit26 commented 2 years ago

The package is updated. Please check the new version. Thank you for your reporting.

lit26 commented 2 years ago

Is the issue you mentioned related to the package and is the issue solved since it is merged?

lit26 commented 2 years ago

Hi @JerBouma, it seems the indexing causes the problem in the your testing(https://github.com/OpenBB-finance/OpenBBTerminal/runs/5729494247?check_suite_focus=true). The latest version has removed the indexing and use the css class selector. Hope that helps.

JerBouma commented 2 years ago

Hi @lit26, yes it relates to that indeed. The reason we haven't updated yet is due to the fact that it does break some other commands as well in a different area of our package which is most likely due to our own code. Therefore, we are not updating just yet. Thanks for the heads up nonetheless though!

lit26 commented 2 years ago

No worries. Feel free to post issues if any.