changes made in utils.py, quote.py and screener/overview.py - Githubissues

lit26 / finvizfinance

Finviz analysis python library.

https://finvizfinance.readthedocs.io/en/latest/

MIT License

515 stars 85 forks source link

changes made in utils.py, quote.py and screener/overview.py #59

Closed huzaifazahoor closed 2 years ago

huzaifazahoor commented 2 years ago

Description

I have added three features. I'll address them one by one. 1) I have added the get_header() function in utils.py.

This function will choose new user-agent on every request call. It will make us more anonymous.
Then in the web_scrap() and image_scrap(), I'm calling this get_header() function.
The header in the top is remain same, I have not deleted it, because it is using on the other places.

2) I have added the code in the quote.py.

EPS Next Y is two values in the ticker detail page. One is dollar amount and other one is percentage.
I have added the code which is Checking that if the EPS Next Y is already in the dictionary, then change the header which is EPS Next Y Percentage.

3) I have added the sleep(1) code in screener/overview.py

Actually, finviz does not support continuous calls. It blocks if we call consecutive requests.
So, I have added sleep(1) in loop. So, it now doesn't block us.

Type of change

[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

What you did

get_header() in utils.py
sleep(1) in screener/overview.py
Code in quote.py

lit26 commented 2 years ago

Can you add sleep function to other similar functions? The pr looks good. I will fix some other issues and merge this in.

lit26 commented 2 years ago

Your code is merged. Thank you for your contributions.