[Android Bootcamp] Project 2 - Review my TwitterClient app

[lita]

/cc @codepathreview @codepath

Unfortunately, it was my birthday on Saturday so I couldn't finish all the optionals. But hopefully it good enough. Will do all the optionals next week.

[codepathreview]

:+1: Excellent work again, Lita. Great to see you put in the effort to turn in a polished assignment. BTW, belated birthday wishes to you from the entire @codepath family.

A few notes after checking out the code:

• Good to see you were able to format the timestamp cleanly (consider externalizing to utils class)
• Nice to see you used the SwipeRefreshLayout for easy timeline refreshes
• Good to see you refreshed the timeline after composing a new tweet
• Great job implementing the compose tweet feature as a dialog
• Good to see you added ActiveAndroid annotations to the models for offline usage
• Nice touch with the character count being displayed while the user composes a tweet and notifying the user in red if the count exceeds 140 chars. Great job on LinkifiedTextView
• Consider activating functionality like retweet and favorite using the respective endpoints.

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.

[lita]

Hello! Yes, I didn't get a chance around favorite/retweeting. That should be easily added.

Right as you were reviewing my project, I implemented embedded media and would love to hear your thoughts.

Also, in the mailing list, people were saying that they needed to save the signed in user information in preferences, which I didn't need to do. Where can I look into doing that?

[nesquena]

Also, in the mailing list, people were saying that they needed to save the signed in user information in preferences, which I didn't need to do. Where can I look into doing that?

The idea here was that during login, people would hit the verify_credentials endpoint and then cache the relevant data to preferences. They would then access the cached username or avatar for the compose dialog or elsewhere. This isn't strictly required but it's a good way to get familiar with preferences and caching content which is common within a mobile app.

[lita]

Ah gotcha! Yea, I was also hitting the verify_credentials endpoint to get the user profile, but did it at every launch. I wasn't running into the issue of getting the credentials block, unlike some people. Might be because I was using the simulator.