search

litaio / lita-default-handlers

A set of handlers included by default in Lita.
MIT License
3 stars 6 forks source link

Improve help handler usability #3

Closed t33chong closed 8 years ago

t33chong commented 8 years ago

Changes to the help handler made in #1 required that the user be familiar with the internals of the bot, e.g. knowing which handler namespace a particular command is defined under in order to find it. This PR removes the help HANDLER STRING syntax and simplifies it to help STRING, where the argument can represent either the name of a handler or a substring on which to filter all commands.

Example of usage and output:

!help log Handler 'log' defines the following commands: !log LEVEL MESSAGE - Log a message to Lita's Logger object. Valid levels: UNKNOWN, FATAL, ERROR, WARN, INFO, DEBUG

!locker log

jimmycuadra commented 8 years ago

Given the odd position this plugin is in w/r/t Lita 5, I think it's OK for CI to fail. I'd rather that currently than a bunch of hacks to get CI to pass added to the code. Can you revert all but your first commit (and force push so the PR is just one commit)? The changes look great.

t33chong commented 8 years ago

@jimmycuadra Thanks - done!