search

litaio / lita-hipchat

A HipChat adapter for Lita.
MIT License
38 stars 27 forks source link

Specify hipchat server address #17

Closed shusugmt closed 9 years ago

shusugmt commented 9 years ago

Add an ability to connect to self managed HipChat Server.

jimmycuadra commented 9 years ago

Thanks for the PR! I left a couple notes.

shusugmt commented 9 years ago

Thanks for the comment. I made two mistakes... 1. garbage vim swp file, 2. in commit comment 9645191 "conditional" shoud be "positional" :p

jimmycuadra commented 9 years ago

Sorry for the delay! I'm gonna sign up for the HipChat Server beta and give this a try first. In the meantime, would you mind rebasing to squash your commits down to one?

shusugmt commented 9 years ago

Any updates on this?

jimmycuadra commented 9 years ago

I wasn't able to get a HipChat server running via the OVA image they provide. It errored out during boot. I will give the AMI a try and see if that works.

shusugmt commented 9 years ago

Thanks. FYI you should choose c3.large or faster instance when you use HipChat Server AMI as stated in their document (https://confluence.atlassian.com/display/HC/Deploying+HipChat+Server) I tried t1.micro first, but it never boot up maybe because of the lack of CPU or memory resource.

amaltson commented 9 years ago

:+1: on this patch. It works on our local HipChat Server installation.

jimmycuadra commented 9 years ago

Thank you! Released in v2.1.0.

amaltson commented 9 years ago

Just upgrade to v2.1.0, working smoothly. Thanks!