search

litaio / lita

ChatOps for Ruby.
https://www.lita.io
MIT License
1.68k stars 178 forks source link

Improve build: use newer JRuby, enable build on docker and add GitLab CI support #195

Closed brodock closed 3 years ago

brodock commented 8 years ago

This pull request, updates JRuby version to a more recent one that will actually build and pass the specs.

It also provides an alternative to redefine Redis host and port for use during test execution phase.

I've tried many alternatives to make this possible, but neither worked, this was the closest I got.

It also adds support for building with GitLab CI (you can see it building here: https://gitlab.com/brodock/lita/pipelines/3767259)

To use GitLab CI, you have to host the repository there (this can be done by mirroring it easily using the import tool).

This will fix #184

jimmycuadra commented 8 years ago

Thanks for the PR! The JRuby bump is a no-brainer, so I'd definitely like to pull that in. I don't think maintaining anything GitLab-specific makes sense in the main repo since it is not hosted there. For the Redis configuration, I'd rather expose explicitly configuration attributes than use environment variables. Something like config.test_redis.host = "whatever". Might be better to split that off into a different PR since it's not related to the JRuby version and might need a few iterations.