search

litchie / exult-ios

Exult ( http://exult.sourceforge.net/ )
GNU General Public License v2.0
42 stars 8 forks source link

Shortcutbar implementation crashes Exult on loading a savegame #21

Closed DominusExult closed 8 years ago

DominusExult commented 9 years ago

e12c5bc8b84fee473cc8ac3078a8e9568de845ef make Exult crash on loading a savegame.

Steps to reproduce:

Something in the cleaning up of the gump is crashing according to Xcode.

DominusExult commented 8 years ago

Tried to debug this more but didn't succeed. Something with the gump is not right and the cleanup fails...

litchie commented 8 years ago

This is in fact a regression. Will fix it as soon as possible.

DominusExult commented 8 years ago

Heya, thanks for the crash fix, but now the shortcutbar is no longer there on loading a savegame :)

litchie commented 8 years ago

Are you sure? I still have it after load a game.

litchie commented 8 years ago

If you are still seeing this bug, can you share a saved game file so that I can try to reproduce the problem?

DominusExult commented 8 years ago

Actually the shortcut gump does not show at all anymore with this change. Clean build, clean exult.cfg, either starting a new game or loading a savegame. (btw. you comitted some autotool files (compile, config.guess, missing))

DominusExult commented 8 years ago

Just tested it again. No luck with Xcode 7.0.1 and an iPad on iOS 9.0.2. No luck with Xcode 7.1 beta 3 and an iPhone 6 on iOS 9.1 beta5. In both cases the shortcut bar is no shown with these changes :(