litchie / exult-ios

Exult ( http://exult.sourceforge.net/ )
GNU General Public License v2.0
42 stars 8 forks source link

Changing video options kills the dpad and menu button #7

Closed DominusExult closed 8 years ago

DominusExult commented 9 years ago

changing anything in the resolutions loses dpad and menu.

litchie commented 9 years ago

Where did you change the resolution?

DominusExult commented 9 years ago

During gameplay, press your menu button, then press "graphics options".

Am 08.02.2015 um 11:42 schrieb Chaoji Li notifications@github.com:

Where did you change the resolution?

— Reply to this email directly or view it on GitHub.

andwan0 commented 9 years ago

I play between 320x200 (zoomed so I can see those small items/rings) ... and 640x480 so I can see the map better. Yes, changing resolutions kills the dpad & menu button... which means I have to forceibly kill the app & restart.

DominusExult commented 9 years ago

I've traced this back to https://github.com/litchie/exult-ios/blob/master/gamewin.cc#L920

win->resized(neww, newh, newfs, newgw, newgh, newsc, newsclr, newfill, newfillsclr);

commenting that makes video changes not kill the touchUI - of course then every video change is not taking until you restart :) This is as far as I can debug it :(

Quickest way to test is:

DominusExult commented 9 years ago

with breakpoints set in xcode the point when it goes bad, the TouchUI disappears, is at https://github.com/litchie/exult-ios/blob/master/imagewin/imagewin.cc#L1023

DominusExult commented 8 years ago

when I comment the condition ´´´ if (dpad == nil) { ´´´ in - (void)showGameControls of ios_utils.mm the TouchUI will reappear when I close the settings gump, Of course this is no solution as it will put layers upon layers on the TouchUI :) But it may point you where the problem is...

DominusExult commented 8 years ago

awesome! many thanks!

litchie commented 8 years ago

My problem is that screen will shrink by half to the center after resolution change, which makes touch very difficult. I don't know if that's ok.

DominusExult commented 8 years ago

That should only happen if you set scaler to 1 and fill mode to center. With which graphics options does that happen to you? (Also a big problem is that the "touch zone" isn't alligned with the shortcut button on other resolutions than the default one)

litchie commented 8 years ago

Yes, I guess it's exactly what I did. I am wondering what's your settings?

video options

The display

DominusExult commented 8 years ago

To debug the varios shortcut bar things? Change back to "scaling 2" but enable "aspect correction" to see how it doesn't apply the changes to the shortcutbar rendering until you restart exult. Or give Exult a bigger resolution and set game area to auto to experience the problem of click area no longer alligning with the shortcutbar button.

DominusExult commented 8 years ago

My recent commits broke this again. Will see what I broke tomorrow. Sorry